[ltp] [patch 05/11] ibm-acpi: clean up fan_read

Henrique de Moraes Holschuh linux-thinkpad@linux-thinkpad.org
Wed, 11 Oct 2006 23:12:21 -0300


On Thu, 12 Oct 2006, Stefan Schmidt wrote:
> On Mon, 2006-10-09 at 09:41, Henrique de Moraes Holschuh wrote:
> > The patch also changes the userspace ABI to return "status: unavailable" when
> > neither fan status or fan control are possible.
> 
> Change in meaning of extend or in meaining of remove old things and
> add new?

The old code would return garbage in this case.  Think of it as a bug fix.
It is a change because instead of returning invalid crap, it now returns
something that makes sense.

> Kernel hackers don't like remove old stuff from userspace ABI. Extend

This is not exactly true. You cannot do it "just because", but sound
technical reasons are often quite acceptable.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh