[ltp] Re: [ibm-acpi-devel] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

[Henrique de Moraes Holschuh]

On Wed, 03 Oct 2007, Chris Hanson wrote:
> Henrique de Moraes Holschuh wrote:
> > Better use this one instead...
> 
> The patch made no difference; it still gets stuck generating EINVAL.

Please try this one, and see if it produces any debug output.

diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index a4884aa..0c6433f 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -3713,8 +3713,11 @@ static int brightness_set(int value)
 	int cmos_cmd, inc, i, res;
 	int current_value;
 
-	if (value > ((tp_features.bright_16levels)? 15 : 7))
+	if (value > ((tp_features.bright_16levels)? 15 : 7)) {
+		printk(IBM_ERR "debug: over bounds brightness: %d\n",
+			 value);
 		return -EINVAL;
+	}
 
 	res = mutex_lock_interruptible(&brightness_mutex);
 	if (res < 0)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh