[ltp] Re: tp_smapi 0.34 and hdaps

linux-thinkpad@linux-thinkpad.org linux-thinkpad@linux-thinkpad.org
Sun, 20 Jan 2008 19:35:44 +0100


> Thanks for the patch!

no reason :)

> I'm not sure the more restricted approach, with  
> model checking, is worth the trouble, given that we've never seen the
> (1,0,0,0) values on old models. If we go this route, we'll need to
> aggressively maintain the whitelist forever for hdaps to work at all
> on new models. If we just allow the (1,0,0,0) in hdaps_check_ec in

We could accept all values (all or only 1,0,0,0 and 0,60,0,0 ?) on unknown 
models and restrict them on known thinkpads. maybe I will update the patch 
tomorrow.