[ltp] Re: [RESEND] [PATCH 2/3] Introduce acpi_root_table=rsdt boot param and dmi list to force rsdt

[Thomas Renninger]

On Monday 20 October 2008 17:31:53 Henrique de Moraes Holschuh wrote:
> On Mon, 20 Oct 2008, Matthew Garrett wrote:
> > On Sun, Oct 19, 2008 at 11:50:55PM +0200, Thomas Renninger wrote:
> > > Introduce acpi_root_table=rsdt boot param and dmi list to force rsdt
> > >
> > > References: http://bugzilla.kernel.org/show_bug.cgi?id=8246
> > >
> > > Blacklist R40e, R51e and T40, T40p, T41, T41p, T42, T42p, R50 and R50p
> > > ThinkPads to use the RSDT instead of the XSDT.
> >
> > I'm very sceptical about this. All of these machines were released years
> > before Vista, which makes me unsure about the diagnosis that this is
> > something to do with Vista readyness.
>
> I believe you will find stuff broken due to Vista Readyness badly
> retro-fitted only on the Z-series and also the T60.
>
> The R51e (BIOS TP-78) does NOT share a BIOS with the T40-T42 or any of the
> two R51 base models. The bugzilla bug report really cannot be used against
> them.  Thomas, do you have extra data not in the bug report that causes you
> to doubt the TP-1R BIOS?

Len, can you remove this part of the dmi entry then:
+       {
+           .ident = "ThinkPad ", /* T40, T40p, T41, T41p, T42, T42p
+                                    R50, R50p */
+           .matches = {
+               DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
+               DMI_MATCH(DMI_BIOS_VERSION, "1RET")},
+       },

The others (these BIOSes seem to not be shared between that many machines) 
were tested that this patchset fixes sever bugs:
  - system freeze when using C-states on R40e
  - much faster booting on R50e

Thanks,

     Thomas