[ltp] thinkpad-acpi release 0.23-20090920 uploaded to ibm-acpi.sf.net

[Henrique de Moraes Holschuh]

On Wed, 23 Sep 2009, Damjan wrote:
> thinkpad_acpi: Standard ACPI backlight interface available, not loading native one.

Well, you don't use any of the codepaths that were changed in the
brightness stuff :)

> input: ThinkPad Extra Buttons as /devices/virtual/input/input118

And if all your hotkeys are working fine, I didn't break the hotkey driver
too badly ;-)

> and everything seems fine (maybe you should've been more specific what
> to test). 

brightness changes, through /proc/acpi/ibm/brightness or the sysfs backlight
class.  But it is not active on your ThinkPad, you're using ACPI video for
that (which is fine).

> I notice only one strange thing, but I beleive it was the same before,
> Fn+F2 or F3 (and some other) generates 2 HAL events (lshal -m):
> 04:53:24.639: computer condition ButtonPressed = Fn+F2
> 04:53:24.639: computer_logicaldev_input_5 condition ButtonPressed = coffee
> 04:53:25.966: computer_logicaldev_input_5 condition ButtonPressed = battery
> 04:53:25.966: computer condition ButtonPressed = display_off

HAL must be doing that, thinkpad-acpi is unable to issue two keycodes per
hotkey.

> > BTW: help is appreciated to verify if the driver is getting the
> > brightness mode right on the various IBM thinkpads.  The driver will log
> > a notice asking for a report in that case.
> 
> nothing here

Yeah, it is a change that only affects IBM ThinkPads, and a lot of them are
already whitelisted.

Thanks for the report.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh