[ltp] Re: [PATCH] {RFC} iwlagn: make 'broken' powersaving a module parameter for 3945/4965

Stefan Monnier linux-thinkpad@linux-thinkpad.org
Sat, 27 Mar 2010 14:23:37 -0400


>> > A while back Tino Keitel posted a patch which could re-enable the
>> > powersaving features of the Intel WiFi 4965 cards.  As some of you may
>> > know, the driver's powersaving code was found to be buggy and was
>> > disabled in one of the recent 2.6.3x kernels (I forget which one).  As
>> > it turns out it's not too bad -- IIRC it doesn't handle suspend/resume
>> > properly, but works fine otherwise.
>> IIUC the problem is that there is now new power management code that
>> changes the power-ssaving level dynamically, and that's the one that
>> causes problem.  So IIUC the problem will show up even if you don't
>> suspend/resume.
>> OTOH, I have posted a feature-request to get back the old "static"
>> power-management on those cards where the new code needs to be disabled.
> Hm.  I've been using the broken power management for about a month now,
> and I can't say I've noticed any problems.

Good to hear.  Please post your patch and your experience to the
wireless-testing mailing-list.

> TBH, even if it did have issues I'd probably still use it, since it
> produces a sizable decrease in power consumption.

100% agreement.  The removal of the power-saving feature for the 3945
card is a very serious issue, AFAIC.


        Stefan