[ltp] Good news for hda-intel firmware beeps

Henrique de Moraes Holschuh linux-thinkpad@linux-thinkpad.org
Sun, 28 Mar 2010 10:16:39 -0300


On Sat, 27 Mar 2010, kionez wrote:
> #include <Henrique de Moraes Holschuh.h>   // created 27/03/2010 16:56
> 
> > Please tell me where to get the patch and who to pester to get that fix
> > backported to -stable!
> > 
> > If you can point me to the ML threads, it's even better.
> 
> I'd reported them on the first post, anyway, here's the thread on
> alsa-user's ML:
> 
> http://thread.gmane.org/gmane.linux.alsa.user/34001
> 
> And here is the patch committed by Jaroslav Kysela:
> 
> http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=0bf0e5a6f304ac1bc93a80cdd68b4d91f3519eb5
> 
> > Also, if you didn't do so yet, please make sure you reply to the patch
> with
> > a "Tested-by: kionez <kionez@anche.no>".
> 
> I would like to reply, but i can't find any post in alsa-users ML, maybe
> i have to subscribe to alsa-devel?

You can just look at the commit, and send the tested-by to everyone listed
in the commit as: author, commiter, and in the "CC:" lines of the commit log
if there are any, and also the relevant subsystem ML (alsa-devel).  The
subjet should be: "Re: ALSA: hda-intel - AD1984 thinkpad - add analog beep
input control".

Send it to: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org

Make sure to have this in the body of the message (quoted):

>commit	0bf0e5a6f304ac1bc93a80cdd68b4d91f3519eb5
>
>ALSA: hda-intel - AD1984 thinkpad - add analog beep input control
>
>For Lenovo Thinkpad T61/X61, the analog beep input is connected
>to node 0x20, index 3. Move the digital beep mute/volume controls
>as "Digital Beep" and create analog beep controls for mentioned node.
>
>Signed-off-by: Jaroslav Kysela <perex@perex.cz>

Although since it is already commited, it might happen that the tested-by
won't be added if they use a "pure git workflow". Some trees do, some don't
(e.g. ACPI doesn't, and would add the tested-by without fuss since the only
time a ACPI commit is set in stone is when it is sent to Linus for merging).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh