[ltp] thinkpad-smapi from tp-smapi-source 0.40-8 does not build
for 2.6.37-rc3
Dominik Stadler
linux-thinkpad@linux-thinkpad.org
Wed, 24 Nov 2010 21:38:25 +0100
--0016361e7f1c9c53590495d278a8
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
I think there is some similar discussion at
https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/673343, a possible
patch is available in the debian bug at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D602367
Note that I just follow the Ubuntu bugs, I didn't try any of those as I am
not using that kernel version yet so I cannot tell if they actually work...
Thanks... Dominik.
On Wed, Nov 24, 2010 at 10:57 AM, Henrique de Moraes Holschuh <
hmh@hmh.eng.br> wrote:
> On Wed, 24 Nov 2010, Martin Steigerwald wrote:
> > Am Mittwoch 24 November 2010 schrieb Henrique de Moraes Holschuh:
> > > On Tue, 23 Nov 2010, Martin Steigerwald wrote:
> > > > m-a a-i tp-smapi fails to build on 2.6.37-rc3, while build works on
> > >
> > > > 2.6.36:
> > > ...
> > >
> > > > /usr/src/modules/tp-smapi/thinkpad_ec.c:91: warning: type defaults =
to
> > > > =91int=92 in declaration of =91DECLARE_MUTEX=92
> > >
> > > Hmm, needs to be changed to either use semasphores or mutexes. The o=
ld
> > > semaphore-as-mutex is gone in 2.6.36.
> >
> > In 2.6.36 it still compiled, so must be a change between 2.6.36 and
> > 2.6.37.
>
> Yes. commit 4882720b267b7b1d1b0ce08334b205f0329d4615 and a few others
> before it.
>
> It should not be too difficult, one can either use semasphores (if
> they're needed in interrupt context), or the new mutexes (if they are
> not needed in interrupt context). I don't think thinkpad-ec does
> anything funny, so it should not cause problems with the strict mutex
> constraints and the lock/mutex validator.
>
> --
> "One disk to rule them all, One disk to find them. One disk to bring
> them all and in the darkness grind them. In the Land of Redmond
> where the shadows lie." -- The Silicon Valley Tarot
> Henrique Holschuh
> --
> The linux-thinkpad mailing list home page is at:
> http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad
>
--0016361e7f1c9c53590495d278a8
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
I think there is some similar discussion at <a href=3D"https://bugs.launchp=
ad.net/ubuntu/+source/tp-smapi/+bug/673343">https://bugs.launchpad.net/ubun=
tu/+source/tp-smapi/+bug/673343</a>, a possible patch is available in the d=
ebian bug at <a href=3D"http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D=
602367">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D602367</a><br>
<br>Note that I just follow the Ubuntu bugs, I didn't try any of those =
as I am not using that kernel version yet so I cannot tell if they actually=
work...<br><br>Thanks... Dominik.<br><br><div class=3D"gmail_quote">On Wed=
, Nov 24, 2010 at 10:57 AM, Henrique de Moraes Holschuh <span dir=3D"ltr">&=
lt;<a href=3D"mailto:hmh@hmh.eng.br">hmh@hmh.eng.br</a>></span> wrote:<b=
r>
<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; borde=
r-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class=3D"im"=
>On Wed, 24 Nov 2010, Martin Steigerwald wrote:<br>
> Am Mittwoch 24 November 2010 schrieb Henrique de Moraes Holschuh:<br>
> > On Tue, 23 Nov 2010, Martin Steigerwald wrote:<br>
> > > m-a a-i tp-smapi fails to build on 2.6.37-rc3, while build w=
orks on<br>
> ><br>
> > > 2.6.36:<br>
> > ...<br>
> ><br>
> > > /usr/src/modules/tp-smapi/thinkpad_ec.c:91: warning: type de=
faults to<br>
> > > =91int=92 in declaration of =91DECLARE_MUTEX=92<br>
> ><br>
> > Hmm, needs to be changed to either use semasphores or mutexes. =
=A0The old<br>
> > semaphore-as-mutex is gone in 2.6.36.<br>
><br>
> In 2.6.36 it still compiled, so must be a change between 2.6.36 and<br=
>
> 2.6.37.<br>
<br>
</div>Yes. =A0commit 4882720b267b7b1d1b0ce08334b205f0329d4615 and a few oth=
ers<br>
before it.<br>
<br>
It should not be too difficult, one can either use semasphores (if<br>
they're needed in interrupt context), or the new mutexes (if they are<b=
r>
not needed in interrupt context). =A0I don't think thinkpad-ec does<br>
anything funny, so it should not cause problems with the strict mutex<br>
constraints and the lock/mutex validator.<br>
<div><div></div><div class=3D"h5"><br>
--<br>
=A0"One disk to rule them all, One disk to find them. One disk to bri=
ng<br>
=A0them all and in the darkness grind them. In the Land of Redmond<br>
=A0where the shadows lie." -- The Silicon Valley Tarot<br>
=A0Henrique Holschuh<br>
--<br>
The linux-thinkpad mailing list home page is at:<br>
<a href=3D"http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpa=
d" target=3D"_blank">http://mailman.linux-thinkpad.org/mailman/listinfo/lin=
ux-thinkpad</a><br>
</div></div></blockquote></div><br>
--0016361e7f1c9c53590495d278a8--