[ltp] ibm-acpi 0.11 compilation problems with Fedora devel 2.6.13-rc5

[Martin Hermanowski]

--gMR3gsNFwZpnI/Ts
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 04, 2005 at 09:59:56PM +0100, honey@gneek.com wrote:
> OK, I'm not a coder, so this one has me a bit baffled... I just
> installed a development kernel from Fedora (which is actually
> 2.6.13-rc5 with the usual Fedora patches) and ibm_acpi won't compile.
> I'm using Matthias Hensler's kernel with swsusp2/fbsplash included -
> and having to use his latest devel version to test for file corruption
> fixes in the swsusp2/suspend2 project.
>=20
> When I try to compile ibm_acpi 0.11 I get the following error:
>=20
> # make
> make -C /lib/modules/2.6.12-1.1446_FC4_cubbi1_swsusp2/build
> SUBDIRS=3D/root/src/ibm-acpi-0.11 modules
> make[1]: Entering directory=20
> `/usr/src/kernels/2.6.12-1.1446_FC4_cubbi1_swsusp2-i686' CC [M] =20
> /root/src/ibm-acpi-0.11/ibm_acpi.o
> /root/src/ibm-acpi-0.11/ibm_acpi.c:1756: error: conflicting types for=20
> 'device_add'
> include/linux/device.h:326: error: previous declaration of 'device_add' w=
as=20
> here
> make[2]: *** [/root/src/ibm-acpi-0.11/ibm_acpi.o] Error 1
>=20
> A declaration for device_add appears in both the current kernel's
> include/linux/device.h and the previous kernel's (which compiled
> fine) and are identical:
>=20
> extern int device_add(struct device * dev);
>=20
> I'm sure if I was a coder I could understand this in a minute, but
> I'm not - wondering if anyone has come across this, or Borislav might
> have an idea?  I bet I'll kick myself when I find out...

I had the same problem when installing 2.6.13-rc4-mm1. There seems to be
a new funtion in the linux kernel named `device_add', so I just renamed
the two occurrences of `device_add' in the ibm-acpi module to
`ibmacpi_device_add', and it worked like a charm. Since this function
doesn't actally do anything, I suspect that this cannont break anything.

Regards,
Martin

--gMR3gsNFwZpnI/Ts
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC8zH+mGb6Npij0ewRAm6VAJ9dq3tCAIOiH8iOYV/wG/3I2Qk70gCeOEEH
jcMhJ5r7GtTVrMTUoDIfEno=
=vTzc
-----END PGP SIGNATURE-----

--gMR3gsNFwZpnI/Ts--