[ltp] [ACPI] Thinkpad radeon_pm.c patches (T40 2373-8CG with this setup is not affected by the power drain)

Benjamin Herrenschmidt linux-thinkpad@linux-thinkpad.org
Sat, 05 Feb 2005 10:43:26 +1100


On Fri, 2005-02-04 at 09:26 -0500, Pete Toscano wrote:
> Bob Alexander wrote:
> > To do a useful work someone should input all/most/many Thinkpads with a 
> > Radeon types/models into the patch (I do not know how to do that).
> 
> I was thinking about this myself.  If people want to send me their 
> machine's stanzas, I'll start collecting them and adding them to the 
> drivers/video/aty/radeon_pm.c patch (radeonfb-thinkpad-pm-2.patch).  So 
> far, I've just added my own.  I'll be sure to keep passing this on to 
> the maintainer of this file (Paul? Ben?)

Me.

> I can't test everyone's info, so please test on your own and only send 
> me the stanza when you've tested on your own box.
> 
> Here's the little bit I've got....
> 
> .ident = "IBM ThinkPad T40 (2373-94U)",
> .matches = {
>          DMI_MATCH(DMI_SYS_VENDOR, "IBM"),
>          DMI_MATCH(DMI_PRODUCT_NAME, "237394U"),
> },
> 
> .ident = "IBM ThinkPad T41 (2373-2FG)",
> .matches = {
>          DMI_MATCH(DMI_SYS_VENDOR, "IBM"),
>          DMI_MATCH(DMI_PRODUCT_NAME, "23732FG"),
> },
> 
> .ident = "IBM ThinkPad T41 (2379-DJU)",
> .matches = {
>          DMI_MATCH(DMI_SYS_VENDOR, "IBM"),
>          DMI_MATCH(DMI_PRODUCT_NAME, "2379DJU"),
> },

We should add more than that. We should add at least which mobile mode
to put a given mobo. Also, it might be useful to revive the D2 code for
M10 chipsets that paulus figured out back then as well... In fact, you
may be able to put the M9 and M10 to D3 cold state and use my reinit
code to bring them back....

The only annoying thing is the memory mode reg settings. Those are
sort-of hard coded for the values used on powerbooks, they may not fully
apply on all thinkpad models.

I'm trying to get from my contacts at ATI some infos about how to
extract the proper infos from the ROM.

Ben.