[ltp] [PATCH] In-kernel automatic fan control

[Ziga Mahkovec]

On Mon, 2005-11-28 at 20:01 -0500, Yury Polyanskiy wrote:
> I did a small modification to a kernel ibm-acpi driver. 
> It adds "auto" command for fan (in addition to enable/disable). 
> [...]
> Patch against mainstream ibm-acpi-0.11.tar.gz attached.

I'm trying out your patch on T43p and so far it works great.

Minor comment:

> +  int ret = __thermal_raw_read(tmp);
> +  if(ret){
> +  	printk(IBM_ERR "kautofand: can't read temperatures, ret = %d\n", ret);
> +  	errors++;
> +  	if(errors > 10) break;
> +  }

Would it make sense to start the fan here, before breaking out?  If I'm
reading this correctly, this code path allows for kautofand to be
stopped without the fan ever being started back up.

Thanks,
-- 
Ziga