[ltp] ibm-acpi: Get rid of the experimental status for brightness and volume.

Stefan Schmidt linux-thinkpad@linux-thinkpad.org
Thu, 24 Aug 2006 16:40:41 +0200


--VuQYccsttdhdIfIP
Content-Type: multipart/mixed; boundary="SWTRyWv/ijrBap1m"
Content-Disposition: inline


--SWTRyWv/ijrBap1m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello.

Since version 0.11 ecdump, brightness, volume and fan a available in
ibm-acpi, but only if you set experimental=1 on loading.

You released this version at 2005-03-17. So this is quit some time to
see if some of these features make problems.

I think it's ok to make ecdump and fan only available, if loaded with
experimental. As ecdump is only for debugging and explore new features
and fan stop can damage the hardware.

But i see no problem with brightness and volume to be available in the
normal feature set. Anybody can report a real problem with this two?

If not, please apply the attached patch.

regards
Stefan Schmidt

--SWTRyWv/ijrBap1m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ibm-acpi-get-rid-of-experimental-status.patch"

diff -urN linux-2.6.17/drivers/acpi/ibm_acpi.c linux-2.6.17-new/drivers/acpi/ibm_acpi.c
--- linux-2.6.17/drivers/acpi/ibm_acpi.c	2006-06-18 03:49:35.000000000 +0200
+++ linux-2.6.17-new/drivers/acpi/ibm_acpi.c	2006-08-24 15:44:05.000000000 +0200
@@ -1632,13 +1632,11 @@
 	 .name = "brightness",
 	 .read = brightness_read,
 	 .write = brightness_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "volume",
 	 .read = volume_read,
 	 .write = volume_write,
-	 .experimental = 1,
 	 },
 	{
 	 .name = "fan",

--SWTRyWv/ijrBap1m--

--VuQYccsttdhdIfIP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: http://www.datenfreihafen.org/contact.html

iD8DBQFE7bppbNSsvd31FmURAtYSAJ9nN6m9eoJ9PPlslOsenBxaSYU3PwCgoTHq
jRM28F4h2Hr0w5CS08D29RY=
=9kaT
-----END PGP SIGNATURE-----

--VuQYccsttdhdIfIP--