[ltp] [2.6.18] ibm-acpi: thermal sensors and fan control v3

Henrique de Moraes Holschuh linux-thinkpad@linux-thinkpad.org
Mon, 23 Oct 2006 12:13:43 -0300


This is the latest version of the fan-control and extended thermal sensors
patch.  It applies to 2.6.18, and is easily coaxed into applying to
2.6.19-rc.

Changes from the v2 patches:

	* the fan watchdog is included
	* far more compatible with userspace utilities
	* improved detection of the buggy thinkpads and changed the
	  workaround for the common case instead of doing a perfect
	  fix that just gets in the way (it is 100% safe, after all...)
	* improved compatibility with userspace fan control scripts that
	  trigger the disengaged mode constantly (returns speed reading,
	  but marks it as stale).

Please test and comment.  I out of ideas about how to improve these patches'
functionality further, so they are nearly in their final form.  This means
your reports about how well these patches work are very important at this
stage.

I will do a once-over to make the patches even more sysfs-conversion
friendly, and they will be ready for upstream.  This will just rename
functions and shuffle some code around, and will not change any
functionality.

Kudos to the author of the ibm-acpi applet.  It at least attempts to parse
ibm-acpi output properly.  Some other applets out there do such a
substandard job of parsing ibm-acpi output, I was sincerely outraged when I
read their code.  And yes, these applets *are* *currently* *broken*, as
their crap for a parser doesn't handle the older thinkpads like the model
600.  The patch should not break them any further, but they could benefit
heavily from a proper parser.

I will reply to this message with the combined patch (which is easier to
apply), and also with the broken-out patches (which are easier to comment
on and have implementation details better explained).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh