[ltp] Re: [PATCH v2] Re: Battery class driver.

Pavel Machek linux-thinkpad@linux-thinkpad.org
Sat, 28 Oct 2006 18:55:13 +0000


Hi!

> > > Hm. Again we have the question of whether to export 'threshold_pct'
> > > vs.'threshold_abs', or whether to have a separate string property
> > > which says what the 'unit' of the threshold is. I don't care much --
> > > I'll do whatever DavidZ prefers.
> > 
> > Unit is easier to process in HAL in my opinion.
> 
> What about just prepending the unit to the 'threshold' file? Then user
> space can expect the contents of said file to be of the form "%d %s". I
> don't think that violates the "only one value per file" sysfs mantra.

Bad idea... I bet someone will just ignore the units part, because all
the machines he seen had mW there. Just put it into the name:

power_avg_mV

							Pavel

-- 
Thanks for all the (sleeping) penguins.