[ltp] [PATCH] New ibm-acpi patches for extended thermal sensor functionality

Stefan Schmidt linux-thinkpad@linux-thinkpad.org
Sat, 16 Sep 2006 21:19:01 +0200


--MfFXiAuoTsnnDAfZ
Content-Type: text/plain; charset=unknown-8bit
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

On Sat, 2006-09-16 at 15:54, Henrique de Moraes Holschuh wrote:
> On Sat, 16 Sep 2006, Stefan Schmidt wrote:
>=20
> I can certainly help with ibm-acpi, though.  And even if Borislav has lit=
tle
> time for the code, as long as patches sent upstream still get accepted (a=
nd
> someone must be accepting them, 2.6.18 has silently added experimental
> support for enabling/disabling WAN cards, without documenting it).

Intersting, i miss this one. Did Borislav ack this patches, or did
somebody else pick them up without the ack from the current
maintainer?

> > It would be good to fetch all the patches flying around on this list
> > and the wiki and submit them into main. Here are my small list with
>=20
> Sure, one thing at a time.  Fan control goes next, but since there *are*
> firmware bugs at play with fan control, that one needs more thought.

Fair enough. Never tried the fan control on my own.

> > 1. Get rid of the experimental status of some features. See my patch
> > on this ml.
>=20
> But keep ecdump experimental.  Reading EC registers can have side-effects,
> some registers are likely to be reset-on-read.  The EC has some
> functionality that behaves this way, like HDAPS keyboard and mouse activi=
ty
> detection, it is only sane to expect that stuff like that might be in the=
 EC
> register space too.
>=20
> Writing blindly to EC space is *really* dangerous, too.

Of course. I only want to remove the experim=E6ntal status from the save
features. Brightness and volume in my opinion. Ecdump should stay
experimental and fan need to be discussed.

http://www.datenfreihafen.org/~stefan/patches/ibm-acpi-get-rid-of-experimen=
tal-status.patch

> > 4. Get rid of the of the docking feature and push the genric docking
> > driver in main instead.
>=20
> I can't help with that, unfortunately.  I don't own a dock.  But I believe
> the generic docking driver IS in mainline already?

Yes, it should be in 2.6.18. Once this one is out i try it. My point
was, that the dock feature from ibm-acpi and the generic docking
driver have the same goal. This is the reason for the ifdefs around
the dock feature in ibm-acpi.

The longterm goal should be to move the necassary bits for docking
=66rom ibm-acpi to the genric docking driver and eliminate the dock
feature from ibm-acpi.

regards
Stefan Schmidt

--MfFXiAuoTsnnDAfZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: http://www.datenfreihafen.org/contact.html

iD8DBQFFDE4lbNSsvd31FmURAgL1AKCFU1JXKXEB27D9/qhO3iFg5DsdBACdEvVB
pVMaLy1nEP+GKg0fPk1dHuM=
=EMPz
-----END PGP SIGNATURE-----

--MfFXiAuoTsnnDAfZ--