[ltp] [PATCH] New ibm-acpi patches for extended thermal sensor functionality

[Alex Deucher]

On 9/16/06, Stefan Schmidt <stefan@sostec.de> wrote:
> Hello.
>
> On Sat, 2006-09-16 at 15:54, Henrique de Moraes Holschuh wrote:
> > On Sat, 16 Sep 2006, Stefan Schmidt wrote:
> >
> > I can certainly help with ibm-acpi, though.  And even if Borislav has l=
ittle
> > time for the code, as long as patches sent upstream still get accepted =
(and
> > someone must be accepting them, 2.6.18 has silently added experimental
> > support for enabling/disabling WAN cards, without documenting it).
>
> Intersting, i miss this one. Did Borislav ack this patches, or did
> somebody else pick them up without the ack from the current
> maintainer?
>
> > > It would be good to fetch all the patches flying around on this list
> > > and the wiki and submit them into main. Here are my small list with
> >
> > Sure, one thing at a time.  Fan control goes next, but since there *are=
*
> > firmware bugs at play with fan control, that one needs more thought.
>
> Fair enough. Never tried the fan control on my own.
>
> > > 1. Get rid of the experimental status of some features. See my patch
> > > on this ml.
> >
> > But keep ecdump experimental.  Reading EC registers can have side-effec=
ts,
> > some registers are likely to be reset-on-read.  The EC has some
> > functionality that behaves this way, like HDAPS keyboard and mouse acti=
vity
> > detection, it is only sane to expect that stuff like that might be in t=
he EC
> > register space too.
> >
> > Writing blindly to EC space is *really* dangerous, too.
>
> Of course. I only want to remove the experim=E6ntal status from the save
> features. Brightness and volume in my opinion. Ecdump should stay
> experimental and fan need to be discussed.
>
> http://www.datenfreihafen.org/~stefan/patches/ibm-acpi-get-rid-of-experim=
ental-status.patch
>
> > > 4. Get rid of the of the docking feature and push the genric docking
> > > driver in main instead.
> >
> > I can't help with that, unfortunately.  I don't own a dock.  But I beli=
eve
> > the generic docking driver IS in mainline already?
>
> Yes, it should be in 2.6.18. Once this one is out i try it. My point
> was, that the dock feature from ibm-acpi and the generic docking
> driver have the same goal. This is the reason for the ifdefs around
> the dock feature in ibm-acpi.
>
> The longterm goal should be to move the necassary bits for docking
> from ibm-acpi to the genric docking driver and eliminate the dock
> feature from ibm-acpi.

looks like it's been taken care of already:

http://www.kernel.org/git/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3D=
commit;h=3D63e5f248c4b748690b5180aa1b4b10eac51bb0e1

>
> regards
> Stefan Schmidt
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
> Comment: http://www.datenfreihafen.org/contact.html
>
> iD8DBQFFDE4lbNSsvd31FmURAgL1AKCFU1JXKXEB27D9/qhO3iFg5DsdBACdEvVB
> pVMaLy1nEP+GKg0fPk1dHuM=3D
> =3DEMPz
> -----END PGP SIGNATURE-----
>
>
>