[ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

[Henrique de Moraes Holschuh]

On Thu, 04 Oct 2007, Jan Gutter wrote:
> On Wed, 2007-10-03 at 21:13 -0300, Henrique de Moraes Holschuh wrote:
> > On Wed, 03 Oct 2007, Henrique de Moraes Holschuh wrote:
> > > You found the problem.  It is not doing a depth-walk to find LCD0._BCL.  I
> > > shall have it fixed soon, there is a ugly and a nice way to do it.
> > 
> > Jeez, it took some doing to get it right.  Here it is, and this time it
> > should work just fine.  Apply on top of the 0.17-20071002 release without
> > the other patches.
> 
> Unfortunately this patch still doesn't work for me :-(
> 
> Just to be absolutely sure, I added a printk after acpi_walk_namespace,
> acpi_walk_namespace returns with ACPI_SUCCESS, but it looks like it
> didn't find BCLL. Argh.

Argh indeed, probably it is screwing up when looking for an
ACPI_TYPE_PACKAGE.  Please change "BCLL" to "_BCL", and ACPI_TYPE_PACKAGE to
ACPI_TYPE_METHOD.  Does that make the driver work?

I don't want to really use ACPI_TYPE_METHOD and _BCL, that's something
Lenovo might decide to add to the T60 and other Lenovo thinkpads with 8
levels for some reason, to support Vista.  If I have to use _BCL, I will
need to actually call it, and parse its results... which is more code to
write, test, and (if it doesn't work at first), waste a lot of time into
debugging.

I will see if I can find a way to test with ACPI_TYPE_PACKAGE looking for
some crap in the T43 DSDT :(  I tested with ACPI_TYPE_METHOD.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh