[ltp] Re: Make disk-protect work on 2.6.24 (was: enabling protect file for hdaps on t61)

Rolf Kutz linux-thinkpad@linux-thinkpad.org
Thu, 14 Feb 2008 12:07:51 +0100


On 13/02/08 12:39 +0100, Elias Oltmanns wrote:
>
>Anyway, there is a temporary solution to this problem. If you apply the
>little patch attached to this email, the usual disk-protect patch will
>work on 2.6.24. This change is supposed to fix a generic problem in
>libata and may eventually be merged upstream, but Tejun Heo (libata
>developer) said that some testing was required first.

Would it be possible to include it in a bugfix
release (2.6.24.x)?

>This change is absolutely safe for everyone using a non-NCQ capable
>system. In particular, ata_piix doesn't support NCQ. If you are using
>ahci and /sys/class/scsi_disk/.../device/queue_depth reports a value
>greater than 1, i.e. NCQ is enabled, then the patch shouldn't cause any
>harm either but it may or may not affect I/O performance.

I will try it, though I'm not affected by the
freezes. Should I run some benchmarks to test
performance with and without the patch? Which
ones?

- Rolf
-- 
I died. [...]
Five seconds later, I'm getting the upside of 15Kv across the nipples.
(These ambulance guys sure know how to party).