[ltp] Re: tp_smapi 0.34 and hdaps

[Shem Multinymous]

Hi,

On Jan 20, 2008 8:35 AM,  <CC.Fan@gmx.de> wrote:
> maybe its better to make the accepted values dependent on the thinkpad model,
> because Lenovo might want to change these values again and we would need to
> whitelist all of these values. I tried to patch tp_smapi-0.33 myself, here
> you can see the result (please dont bash me ;)

Thanks for the patch! I'm not sure the more restricted approach, with
model checking, is worth the trouble, given that we've never seen the
(1,0,0,0) values on old models. If we go this route, we'll need to
aggressively maintain the whitelist forever for hdaps to work at all
on new models. If we just allow the (1,0,0,0) in hdaps_check_ec in
addition to (0,0x60,0,0) then maybe future models will just work.

  Shem