[ltp] Re: [PATCH] Set osi=Linux for the ThinkPad X200s

Matthew Garrett linux-thinkpad@linux-thinkpad.org
Thu, 26 Nov 2009 05:07:48 +0000


On Wed, Nov 25, 2009 at 01:24:50PM -0500, Len Brown wrote:

> Have these been verified as necessary to make sound work on
> the specified models, or are these speculative patches?

To clarify - these patches do *nothing* to make sound work. They change 
the behaviour of the mute key from changing the hardware state of the 
mixer and not sending a key event to instead sending a key event and 
requring that software perform the change. The behavioural change is 
primarily cosmetic rather than functional. I'm not convinced that this 
is a sensible thing to do at this point in the release cycle, given that 
we have no testing of what other behavioural changes the firmware may 
make.

-- 
Matthew Garrett | mjg59@srcf.ucam.org