[ltp] thinkpad-smapi from tp-smapi-source 0.40-8 does not build for 2.6.37-rc3

[Martin Steigerwald]

--nextPart4080968.mb37aGRdI8
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Am Mittwoch 24 November 2010 schrieb Dominik Stadler:
> On Wed, Nov 24, 2010 at 10:57 AM, Henrique de Moraes Holschuh <
>=20
> hmh@hmh.eng.br> wrote:
> > On Wed, 24 Nov 2010, Martin Steigerwald wrote:
> > > Am Mittwoch 24 November 2010 schrieb Henrique de Moraes Holschuh:
> > > > On Tue, 23 Nov 2010, Martin Steigerwald wrote:
> > > > > m-a a-i tp-smapi fails to build on 2.6.37-rc3, while build
> > > > > works on
> > > >=20
> > > > > 2.6.36:
> > > > ...
> > > >=20
> > > > > /usr/src/modules/tp-smapi/thinkpad_ec.c:91: warning: type
> > > > > defaults to =E2=80=98int=E2=80=99 in declaration of =E2=80=98DECL=
ARE_MUTEX=E2=80=99
> > > >=20
> > > > Hmm, needs to be changed to either use semasphores or mutexes.=20
> > > > The old semaphore-as-mutex is gone in 2.6.36.
> > >=20
> > > In 2.6.36 it still compiled, so must be a change between 2.6.36 and
> > > 2.6.37.
> >=20
> > Yes.  commit 4882720b267b7b1d1b0ce08334b205f0329d4615 and a few
> > others before it.
> >=20
> > It should not be too difficult, one can either use semasphores (if
> > they're needed in interrupt context), or the new mutexes (if they are
> > not needed in interrupt context).  I don't think thinkpad-ec does
> > anything funny, so it should not cause problems with the strict mutex
> > constraints and the lock/mutex validator.
>
> I think there is some similar discussion at
> https://bugs.launchpad.net/ubuntu/+source/tp-smapi/+bug/673343, a
> possible patch is available in the debian bug at
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D602367
>=20
> Note that I just follow the Ubuntu bugs, I didn't try any of those as I
> am not using that kernel version yet so I cannot tell if they actually
> work...

Patch from debian bug seems to work.

Its fixed in tp-smapi-source 0.40-9.

Thanks,
=2D-=20
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7

--nextPart4080968.mb37aGRdI8
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAk0Kel0ACgkQmRvqrKWZhMev7QCdEKH+zaLvfMJWZj8enDLGr43k
k84An0rsxtuAqWx7LvNAXx4570vHK9YZ
=wz0p
-----END PGP SIGNATURE-----

--nextPart4080968.mb37aGRdI8--