[ltp] [PATCH] {RFC} iwlagn: make 'broken' powersaving a module parameter for 3945/4965

[Robert Tomsick]

--=-GtHdVzGg3+Spfg42ozsg
Content-Type: multipart/mixed; boundary="=-wNd8ZteXo0vo7XszdVpT"


--=-wNd8ZteXo0vo7XszdVpT
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

A while back Tino Keitel posted a patch which could re-enable the
powersaving features of the Intel WiFi 4965 cards.  As some of you may
know, the driver's powersaving code was found to be buggy and was
disabled in one of the recent 2.6.3x kernels (I forget which one).  As
it turns out it's not too bad -- IIRC it doesn't handle suspend/resume
properly, but works fine otherwise.

I recently got a chance to do some hacking and have come up with a patch
that adds a new parameter 'allow_broken_ps' to the iwlagn driver.  If
set to '1' this will allow power management to be enabled (same as
Tino's patch), but by default will preserve the (safer) upstream
behavior (i.e. don't allow power management for the 3945/4965.)

I figured that for users who rarely suspend (such as myself) this allows
for a nice way to allow intentional use of the flakier code to save
power, whilst still falling back to the safer behavior by default for
users who wish to use suspend, etc.

I've tested it on my ThinkPad X61s (with a 4965) and have found no
issues, but would appreciate any comments.  It's a pretty small patch,
but I'm still quite new to kernel hacking, so any feedback is
appreciated.

Thanks!
-Rob


--=-wNd8ZteXo0vo7XszdVpT
Content-Disposition: attachment; filename=iwlwifi-add-allow_broken_ps-module-parameter.patch
Content-Type: text/x-patch; name=iwlwifi-add-allow_broken_ps-module-parameter.patch;
	charset=UTF-8
Content-Transfer-Encoding: base64

ZGlmZiAtcnVQTiBsaW51eC0yLjYuMzMtcnRoaW5rL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdp
ZmkvaXdsMzk0NS1iYXNlLmMgbGludXgtMi42LjMzLXJ0aGluay1zdGFnaW5nL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL2l3bHdpZmkvaXdsMzk0NS1iYXNlLmMNCi0tLSBsaW51eC0yLjYuMzMtcnRoaW5r
L2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsMzk0NS1iYXNlLmMJMjAxMC0wMy0xNSAx
NDoyMToyOS4wMDAwMDAwMDAgKzAwMDANCisrKyBsaW51eC0yLjYuMzMtcnRoaW5rLXN0YWdpbmcv
ZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9pd2wzOTQ1LWJhc2UuYwkyMDEwLTAzLTE1IDE0
OjQzOjA5LjAwMDAwMDAwMCArMDAwMA0KQEAgLTM5NzUsNiArMzk3NSw5IEBADQogI2VuZGlmDQog
CWlmIChpd2xfYWxsb2NfdHJhZmZpY19tZW0ocHJpdikpDQogCQlJV0xfRVJSKHByaXYsICJOb3Qg
ZW5vdWdoIG1lbW9yeSB0byBnZW5lcmF0ZSB0cmFmZmljIGxvZ1xuIik7DQorCQkNCisJaWYgKGl3
bDM5NDVfbW9kX3BhcmFtcy5hbGxvd19icm9rZW5fcHMpDQorCQlwcml2LT5jZmctPmJyb2tlbl9w
b3dlcnNhdmUgPSBmYWxzZTsNCiANCiAJLyoqKioqKioqKioqKioqKioqKioqKioqKioqKg0KIAkg
KiAyLiBJbml0aWFsaXppbmcgUENJIGJ1cw0KQEAgLTQyNzQsNiArNDI3NywxMSBAQA0KIG1vZHVs
ZV9wYXJhbV9uYW1lZChzd2NyeXB0bywgaXdsMzk0NV9tb2RfcGFyYW1zLnN3X2NyeXB0bywgaW50
LCBTX0lSVUdPKTsNCiBNT0RVTEVfUEFSTV9ERVNDKHN3Y3J5cHRvLA0KIAkJICJ1c2luZyBzb2Z0
d2FyZSBjcnlwdG8gKGRlZmF1bHQgMSBbc29mdHdhcmVdKVxuIik7DQorCQkgDQorbW9kdWxlX3Bh
cmFtX25hbWVkKA0KKwlhbGxvd19icm9rZW5fcHMsIGl3bDM5NDVfbW9kX3BhcmFtcy5hbGxvd19i
cm9rZW5fcHMsIGludCwgU19JUlVHTyk7DQorTU9EVUxFX1BBUk1fREVTQyhhbGxvd19icm9rZW5f
cHMsICJhbGxvdyBicm9rZW4gcG93ZXJzYXZpbmcgKGRlZmF1bHQgMCkiKTsNCisNCiAjaWZkZWYg
Q09ORklHX0lXTFdJRklfREVCVUcNCiBtb2R1bGVfcGFyYW1fbmFtZWQoZGVidWcsIGl3bF9kZWJ1
Z19sZXZlbCwgdWludCwgU19JUlVHTyB8IFNfSVdVU1IpOw0KIE1PRFVMRV9QQVJNX0RFU0MoZGVi
dWcsICJkZWJ1ZyBvdXRwdXQgbWFzayIpOw0KZGlmZiAtcnVQTiBsaW51eC0yLjYuMzMtcnRoaW5r
L2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXdsLTQ5NjUuYyBsaW51eC0yLjYuMzMtcnRo
aW5rLXN0YWdpbmcvZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9pd2wtNDk2NS5jDQotLS0g
bGludXgtMi42LjMzLXJ0aGluay9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC00OTY1
LmMJMjAxMC0wMy0xNSAxNDoyMjoxMS4wMDAwMDAwMDAgKzAwMDANCisrKyBsaW51eC0yLjYuMzMt
cnRoaW5rLXN0YWdpbmcvZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9pd2wtNDk2NS5jCTIw
MTAtMDMtMTUgMTQ6MjQ6NDcuMDAwMDAwMDAwICswMDAwDQpAQCAtNjM4LDYgKzYzOCw5IEBADQog
CSAgICBwcml2LT5jZmctPm1vZF9wYXJhbXMtPm51bV9vZl9xdWV1ZXMgPD0gSVdMNDlfTlVNX1FV
RVVFUykNCiAJCXByaXYtPmNmZy0+bnVtX29mX3F1ZXVlcyA9DQogCQkJcHJpdi0+Y2ZnLT5tb2Rf
cGFyYW1zLT5udW1fb2ZfcXVldWVzOw0KKwkvKiBhbGxvdyB1c2Ugb2YgYnJva2VuIHBvd2Vyc2F2
aW5nIGNvZGUgKi8NCisJaWYgKHByaXYtPmNmZy0+bW9kX3BhcmFtcy0+YWxsb3dfYnJva2VuX3Bz
KQ0KKwkJcHJpdi0+Y2ZnLT5icm9rZW5fcG93ZXJzYXZlID0gZmFsc2U7DQogDQogCXByaXYtPmh3
X3BhcmFtcy5tYXhfdHhxX251bSA9IHByaXYtPmNmZy0+bnVtX29mX3F1ZXVlczsNCiAJcHJpdi0+
aHdfcGFyYW1zLmRtYV9jaG5sX251bSA9IEZINDlfVENTUl9DSE5MX05VTTsNCkBAIC0yMjUzLDYg
KzIyNTYsMTAgQEANCiAJZGlzYWJsZV9od19zY2FuLCBpd2w0OTY1X21vZF9wYXJhbXMuZGlzYWJs
ZV9od19zY2FuLCBpbnQsIFNfSVJVR08pOw0KIE1PRFVMRV9QQVJNX0RFU0MoZGlzYWJsZV9od19z
Y2FuLCAiZGlzYWJsZSBoYXJkd2FyZSBzY2FubmluZyAoZGVmYXVsdCAwKSIpOw0KIA0KK21vZHVs
ZV9wYXJhbV9uYW1lZCgNCisJYWxsb3dfYnJva2VuX3BzLCBpd2w0OTY1X21vZF9wYXJhbXMuYWxs
b3dfYnJva2VuX3BzLCBpbnQsIFNfSVJVR08pOw0KK01PRFVMRV9QQVJNX0RFU0MoYWxsb3dfYnJv
a2VuX3BzLCAiYWxsb3cgYnJva2VuIHBvd2Vyc2F2aW5nIChkZWZhdWx0IDApIik7DQorDQogbW9k
dWxlX3BhcmFtX25hbWVkKHF1ZXVlc19udW0sIGl3bDQ5NjVfbW9kX3BhcmFtcy5udW1fb2ZfcXVl
dWVzLCBpbnQsIFNfSVJVR08pOw0KIE1PRFVMRV9QQVJNX0RFU0MocXVldWVzX251bSwgIm51bWJl
ciBvZiBodyBxdWV1ZXMuIik7DQogLyogMTFuICovDQpkaWZmIC1ydVBOIGxpbnV4LTIuNi4zMy1y
dGhpbmsvZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9pd2wtY29yZS5oIGxpbnV4LTIuNi4z
My1ydGhpbmstc3RhZ2luZy9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC1jb3JlLmgN
Ci0tLSBsaW51eC0yLjYuMzMtcnRoaW5rL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvaXds
LWNvcmUuaAkyMDEwLTAzLTE1IDE0OjIxOjI5LjAwMDAwMDAwMCArMDAwMA0KKysrIGxpbnV4LTIu
Ni4zMy1ydGhpbmstc3RhZ2luZy9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2l3bC1jb3Jl
LmgJMjAxMC0wMy0xNSAxNDo0MjoxNy4wMDAwMDAwMDAgKzAwMDANCkBAIC0yMTEsNiArMjExLDcg
QEANCiAJaW50IGFtc2R1X3NpemVfOEs7CS8qIGRlZjogMSA9IGVuYWJsZSA4SyBhbXNkdSBzaXpl
ICovDQogCWludCBhbnRlbm5hOyAgCQkvKiBkZWY6IDAgPSBib3RoIGFudGVubmFzICh1c2UgZGl2
ZXJzaXR5KSAqLw0KIAlpbnQgcmVzdGFydF9mdzsJCS8qIGRlZjogMSA9IHJlc3RhcnQgZmlybXdh
cmUgKi8NCisJaW50IGFsbG93X2Jyb2tlbl9wczsvKiBkZWY6IDAgPSBkaXNhYmxlIDM5NDUvNDk2
NSBicm9rZW4gcHMgKi8NCiB9Ow0KIA0KIC8qKg0KQEAgLTI4MSw3ICsyODIsNyBAQA0KIAljb25z
dCBib29sIHNoYWRvd19yYW1fc3VwcG9ydDsNCiAJY29uc3QgYm9vbCBodF9ncmVlbmZpZWxkX3N1
cHBvcnQ7DQogCXUxNiBsZWRfY29tcGVuc2F0aW9uOw0KLQljb25zdCBib29sIGJyb2tlbl9wb3dl
cnNhdmU7DQorCWJvb2wgYnJva2VuX3Bvd2Vyc2F2ZTsNCiAJYm9vbCB1c2VfcnRzX2Zvcl9odDsN
CiAJaW50IGNoYWluX25vaXNlX251bV9iZWFjb25zOw0KIAljb25zdCBib29sIHN1cHBvcnRzX2lk
bGU7DQo=


--=-wNd8ZteXo0vo7XszdVpT--

--=-GtHdVzGg3+Spfg42ozsg
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkur6doACgkQd6gWl6secBIIuQCfargQNGDa9WQcux4YEXPJ2zYm
lGoAnjGhan83qFX3QbUoavLP7eMWFi02
=4TU7
-----END PGP SIGNATURE-----

--=-GtHdVzGg3+Spfg42ozsg--